Re: syslogd: Adjust to readutmp changes in Gnulib.

[Collin Funk]

Hi Erik,

Erik Auerswald <auerswal@unix-ag.uni-kl.de> writes:

> On Thu, Sep 05, 2024 at 12:48:03PM +0200, Simon Josefsson wrote:
>> Collin Funk <collin.funk1@gmail.com> writes:
>> 
>> > Can someone give it a look over before pushing?
>> 
>> Could you see if it is feasible to write a self-test that check if this
>> code is doing the right thing?  There is a syslogd self test already, so
>> maybe just make sure it is actually testing what this function is
>> responsible for doing.
>
> There seems to be a test binary tests/readutmp built from tests/readutmp.c
> used in test script tests/utmp.sh to check if code similar to that in
> syslogd and talkd can read utmp information, I think.  Perhaps you can
> also adjust that code to work the same way as in syslogd after your patch.

The Gnulib readutmp test should verify that utmp information could be
read. The test for syslogd would make sure I didn't make mistakes in my
code, which is very possible. :)

That reminds me though, Simon is there any specific reason Inetutils
'make check' doesn't also run Gnulib's checks? I think it is better to
include them to better verify the programs work correctly. And hopefully
catch Gnulib bugs when possible.

Collin