Re: [Bug-librejs] weblabels parsing - script arguments

[Loic J. Duros]

Hi Ward:

Sounds good, but one question though. Many times a script will be
generated dynamically according to the get variables that are given
after the end of the url, like:

http://www.example.org/load-script.php?name=jquery-plugin&user=2313

I've seen a bit of this in the wild. The problem then is that if you
disregard the parameters, then you might be accepting a different
script, with a different license. So we'd have to find a solution to
handle this as well :) or disregard it all together.

Loic


Ward Vandewege <address@hidden> writes:

> Hi all,
>
> When librejs parses a weblabel, it matches the javascript file path
> *including arguments*.
>
> For example, if your html refers to
>
>   http://endsoftpatents.org/wp-includes/js/comment-reply.js?ver=20090102
>
> the entry in the weblabel needs to match that entire string.
>
> This seems undesirable from a practical perspective - the matching should not
> include arguments, instead it should stop at the question mark:
>
>   http://endsoftpatents.org/wp-includes/js/comment-reply.js
>
> Thoughts?
>
> Thanks,
> Ward.