[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for Doc error

From: Graham Percival
Subject: Re: Patch for Doc error
Date: Thu, 13 Apr 2006 22:04:58 -0700

On 13-Apr-06, at 7:44 PM, Cameron Horsburgh wrote:

[Okay, I admit it--it's a very small patch! I'm trying to learn how this
 patching thing all works, so this is more a proof of concept for me as
anything else.

Great! As I've said, I don't require actual patches if you're not comfortable making them, but they _do_ make my life easier. :)

A few notes:
- as a point of style, let's stick {} after the \new Voice.
 \new Voice {
  \set countPercentRepeats = ##t
   \repeat "percent" 4 { c1 }

\new Something
is quite risky; at a later time, you might add \blah2 after the \blah, and not realize why it wasn't working.

- please send patches as attachments. I know that we've had issues with bug-lilypond not accepting any attachments; I'm not certain if they're fixed or not. We still encourage bug reports sent as part of the body of email messages, though.

- HWN would bug you for a Changelog entry, but in the case of small things like this, I just write "Documentation/user/ various: small fixes from mailist". Items like this will just get wrapped up with the next time I make an update like this. If you make substantial changes, a separate Changelog entry would be nice, though.

- we generally make patches from the root directory of the source tree, by doing "cvs diff -u FILES". ie there should be no lilypond/ at the beginning of the file path. It's not any kind of bother to work around (patch -p1 instead of -p0), but you asked for comments, so... :)

Anyway, thanks and applied.  :)

--- lilypond/Documentation/user/basic-notation.itely 2006-04-13 09:27:53.000000000 +1000
+++ basic-notation.itely        2006-04-14 12:28:47.000000000 +1000
@@ -3134,8 +3134,8 @@
 on the @code{countPercentRepeats} property,

-\set countPercentRepeats = ##t
 \new Voice
+\set countPercentRepeats = ##t
   \repeat "percent" 4 { c1 }
 @end lilypond

bug-lilypond mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]