[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Page Spacer gets confused by next-space leading to unusable layout

From: Boris Shingarov
Subject: Re: Page Spacer gets confused by next-space leading to unusable layout
Date: Mon, 17 May 2010 23:58:42 -0400
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20100423 Thunderbird/3.0.4

Hi Joe,

The fact that tight-spacing ignores padding is probably a bug. Do things
work better if you change minimum_distance to (minimum_distance +
padding) in page-layout-problem.cc:286?
As I had posted earlier, changing to (minimum_distance+padding) does
fix exactly the issue I was referring to.
What should we do with it at this point, so that we can see some
progress?  Shall I open a codereview issue on this one line?  doesn't
really seem appropriate, as Joe is the real author of this proposed
Actually, this turns out to be the wrong fix. If you look for
"Markuplines spacing broken: how to set a line padding?" in the
lily-devel archives, you'll see that the zero-padding for markup lines
was intentional (although there should have been a comment to make that
clear), so it is the page breaker that needs to change, not the page

So, something like the attached patch?

I am not sure of the exact logic behind "tight-spacing" (seems convoluted), but when applied to our real-world manuscript, the result looks pretty good. (So I am in a situation opposite to that of Dr. Knuth's anecdote).

Attachment: 3996a06867f193d90758a84032f5395c84d59e11.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]