[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Problem with 2.13.30?

From: Trevor Daniels
Subject: Re: Problem with 2.13.30?
Date: Sun, 29 Aug 2010 23:25:47 +0100

Reinhold Kainhofer wrote Sunday, August 29, 2010 8:33 PM

Thanks, Trevor, for you bisecting... The culprit is actually not the
refactoring, but a bug fix I did before the refactoring (commit
4da9fc65cbf74f4cbbdb01add4d5f341a16f5065 at 10.06.10 13:01).

The problem I fixed with it was quite ugly (and I wonder why noone ever ran into it and complained): If your want to run lilypond-book on a file with *.tex, *.html or *.texi extension, you need to use the --output option, because otherwise the input file would be named the same and the input file
would be overwritten.

[snip description of problem]

As a solution, I changed the input filename from a relative path (which causes problems as soon as the current working dir is changed in a script) to an
absolute path by calling os.path.abspath (...).
Unfortunately, os.path.abspath (...) on Windows has the side-effect of changing all / to \. See http://docs.python.org/library/os.path.html

I don't really see any other way to turn the input path to an absolute path than calling os.path.abspath, in particular, since the input path can already
be an absolute path...

But doesn't this solution create a worse problem
than the original one?  With this fix lilypondbook
cannot be used *at all* under Windows.  The original
problem has a simple workaround which could be documented
easily - the problem created by the fix has no
workaround.  I have to copy an old version of
lilypondbook into every new release in order to get
a working version.  We can't expect users to do that.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]