Issue 1365 in lilypond: convert-ly removes Dynamics blocks too aggressively

[lilypond]

Status: Accepted
Owner: ----
Labels: Type-Scripts Priority-Low

New issue 1365 by percival.music.ca: convert-ly removes Dynamics blocks too  
aggressively
http://code.google.com/p/lilypond/issues/detail?id=1365

spun off from issue 1288.  Note that this is not release-blocking.


Comment 12 by project member v.villenave, Yesterday (23 hours ago)

As far as I can see, dynamics-text-spanner-postfix.ly is OK. However, I  
think that removing the Performer_group is something we want to do. I'm not  
familiar enough with MIDI output to be 100% sure, so I won't update the  
version string myself though.

Delete comment
Comment 13 by project member v.villenave, Yesterday (23 hours ago)

I meant "I *don't* think that removing the performer_group is something we  
want to do", obviously.

Delete comment
Comment 14 by project member percival.music.ca, Yesterday (22 hours ago)

If we don't want to remove that performer_group, then this sounds like a  
bug in convert-ly.  Could you figure out which version conversion rule does  
it, and/or just add a new issue for this?

Delete comment
Comment 15 by project member n.puttock, Yesterday (22 hours ago)

It's the greedy rule I added to remove explicit Dynamics blocks (e.g., from  
the old centred dynamics template).

See 9633a39ac6e996e16f13e2076c565a6ef88e6eca.

Delete comment
Comment 16 by project member v.villenave, Yesterday (18 hours ago)

Oh, I see. Perhaps you should have added "Engraver_group" in your regexp.  
I'll have a look.