[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Issue 897 in lilypond: key signatures should be inherited by all Voi
From: |
lilypond |
Subject: |
Re: Issue 897 in lilypond: key signatures should be inherited by all Voices (no matter their accidental style) |
Date: |
Thu, 03 Mar 2011 10:54:07 +0000 |
Updates:
Owner: tdanielsmusic
Labels: Patch-new
Comment #4 on issue 897 by address@hidden: key signatures
should be inherited by all Voices (no matter their accidental style)
http://code.google.com/p/lilypond/issues/detail?id=897
The patch below fixes this immediate issue and appears to have
no effect on the reg tests. As this fixes a serious problem
(incorrect output) I'd like to push. Any reason why not?
However, a further deeper problem remains. I'll open a separate
issue for this after this patch is pushed.
Trevor
From 1c976acc4cecde62a56d15d2f20fb6ea982aa8d5 Mon Sep 17 00:00:00 2001
From: Trevor Daniels <address@hidden>
Date: Thu, 3 Mar 2011 09:30:50 +0000
Subject: [PATCH] Don't set localKeySignature in Voice context initiation
- fix issue 897
- setting localKeySignature inhibits inheriting keySignature
from parent Staff, leading to issue 897
---
ly/engraver-init.ly | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/ly/engraver-init.ly b/ly/engraver-init.ly
index 91bc12c..ada1b58 100644
--- a/ly/engraver-init.ly
+++ b/ly/engraver-init.ly
@@ -208,7 +208,6 @@ subscripts, slurs, ties, and rests.
You have to instantiate this explicitly if you want to have
multiple voices on the same staff."
- localKeySignature = #'()
\consists "Font_size_engraver"
\consists "Pitched_trill_engraver"
--
1.7.0.4
- Re: Issue 897 in lilypond: key signatures should be inherited by all Voices (no matter their accidental style),
lilypond <=
- Message not available
- Re: Issue 897 in lilypond: key signatures should be inherited by all Voices (no matter their accidental style), lilypond, 2011/03/05
- Message not available
- Re: Issue 897 in lilypond: key signatures should be inherited by all Voices (no matter their accidental style), lilypond, 2011/03/07
- Message not available
- Re: Issue 897 in lilypond: key signatures should be inherited by all Voices (no matter their accidental style), lilypond, 2011/03/08
- Message not available
- Re: Issue 897 in lilypond: key signatures should be inherited by all Voices (no matter their accidental style), lilypond, 2011/03/08
- Message not available
- Re: Issue 897 in lilypond: key signatures should be inherited by all Voices (no matter their accidental style), lilypond, 2011/03/08
- Message not available
- Re: Issue 897 in lilypond: key signatures should be inherited by all Voices (no matter their accidental style), lilypond, 2011/03/08
- Message not available
- Re: Issue 897 in lilypond: key signatures should be inherited by all Voices (no matter their accidental style), lilypond, 2011/03/23