[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

midi.c: always false check

From: Nicolas Kaiser
Subject: midi.c: always false check
Date: Mon, 16 May 2011 13:27:50 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

> I'm not top posting.

Hi there!

I noticed an always false check in midi.c.
'track_size' is unsigned and can't be negative.
Should the check look different, or is it redundant?

Best regards,
Nicolas Kaiser

Signed-off-by: Nicolas Kaiser <address@hidden>
 python/midi.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/python/midi.c b/python/midi.c
index 187268b..0cc5073 100644
--- a/python/midi.c
+++ b/python/midi.c
@@ -364,9 +364,6 @@ pymidi_parse_track (PyObject *self, PyObject *args)
     return 0;
   debug_print ("clocks_max: %d\n", clocks_max);
-  if (track_size < 0)
-    return midi_error (__FUNCTION__,   ": negative track size: ", compat_itoa 
   track_end = track + track_size;
   return midi_parse_track (&track, track_end, clocks_max);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]