[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch-needs_work vs. others

From: David Kastrup
Subject: Re: Patch-needs_work vs. others
Date: Tue, 25 Oct 2011 13:20:33 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux)

Graham Percival <address@hidden> writes:

> On Tue, Oct 25, 2011 at 10:08:34AM +0000, address@hidden wrote:
>> I think that "Needs-evidence" is sufficient for indicating the need
>> for discussion.  The patch status would remain Patch-review (meaning
>> that the patch may or may not be acceptable in his current form but
>> is not going forward).
> Let's move discussion to -devel.  And the answer is "no".
> I do not want to require that the patch meister, much less Patchy,
> understand the difference between various types of Patch-review
> items.  Patch-review should mean "no known problems, and it can go
> on a countdown".
> I'm ok with having two "non-review, non-new" types if you want,
> although I don't see the point of introducing that much
> granularity.  We could have Patch-discuss vs. Patch-needs_work.
>> Once Mike gets through with making master or dev/staging
>> convert-ly-clean, I'll likely prepare a single-commit version (as a
>> merge with the results of the convert-ly run) and put it to
>> dev/staging for final review/countdown.
> No.  dev/staging means "merge and push ASAC" (as soon as
> convenient).  It should only contain patches that have completed a
> countdown, and/or patches that the author wishes to skip the
> review process.

Shrug.  That means to me that this patch is dead.  There is no
conceivable reason that anybody should change its status to anything

We have its current state "Patch-new" -> Patch has received no obvious
checks Of course, I checked the patch.  But even if I decide to put the
"Patch-review" state on myself, this will merely mean: "Patch has passed
obvious checks, and needs review".  Well, it is under review.  Who
should decide to change its need of review, and why?

And in any case, it is _impossible_ to let the patch series get checked
before having a plan for which version the convertrules.py needs to be.
After applying the reviewed patch, one needs to autoconvert before a
check can be made.

And I can't put up several patches with their own convertrules.py if I
don't even know the order of acceptance.

I don't see how to get out of that corner except by deciding I "wish to
skip the review process".  I do that all of the time, basically because
I am an irresponsible asshole.  But it is not fun being an irresponsible
asshole if there is no other choice.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]