[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1356 in lilypond: LilyPond-style comments embedded in aScheme

From: Phil Holmes
Subject: Re: Issue 1356 in lilypond: LilyPond-style comments embedded in aScheme expression can't include special characters
Date: Mon, 28 Nov 2011 18:39:48 -0000

"David Kastrup" <address@hidden> wrote in message news:address@hidden
Graham Percival <address@hidden> writes:

On Mon, Nov 28, 2011 at 11:16:55AM +0100, David Kastrup wrote:
Graham Percival <address@hidden> writes:

> Too hard for people with less than 5 hours of training to
> determine.

I am not sure I understand that rationale.

git log origin

Is it there or not?  Can you think of a _simpler_ test that works for
figuring out something is in _staging_?

Frankly, I don't think it would be horrible if nobody even _tried_
to verify patches and just automatically marked them as verified.
But if people want to do a bit more than that, I think that
checking for the commit in savannah is a decent trade-off.

I disagree.  I consider it a total waste of time to just check if
Savannah has at one time heard about the commit id in whatever context.
The commit id is known to Savannah even if a push is rejected by the
server (since it receives the commit object before making the decision).

Either we connect the status with something that has anything remotely
to do with verification, or we don't.  And if we don't, we should not go
waste anybody's time on it.

Verification is really designed for bugs, and not infrequently finds problems with claimed fixes. Verifying patches is a bolt-on necessity of using Google code to track patches. I have, on a few occasions found a claimed pushed patch with a commitish that points to a patch bearing no resemblance to the claimed fix - so the minimal effort of checking the patch on Savannah relates to the patch can help ensure devs actually push the right patch.

Actually, the verification for a commit id to be in master can be as
simple as

git fetch
git log origin..cf93b1df71253b2686ceabacdf49a47e6908da64

This presumes that the Bug squad can and do run Git, which is a false presumption.

Phil Holmes
Bug Squad

reply via email to

[Prev in Thread] Current Thread [Next in Thread]