bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 2171 in lilypond: Patch: Implements DOM-id property for grobs.


From: lilypond
Subject: Re: Issue 2171 in lilypond: Patch: Implements DOM-id property for grobs.
Date: Fri, 06 Jan 2012 09:10:43 +0000

Updates:
        Labels: -Patch-push Patch-review

Comment #5 on issue 2171 by address@hidden: Patch: Implements DOM-id property for grobs.
http://code.google.com/p/lilypond/issues/detail?id=2171

WTF is this even for? There is no explanation whatsoever in the issue description, there is no explanation in the review, there is no explanation in the code and no documentation and no regtest.

Yes, I overlooked this in the review process, probably since it did not even contain a single sentence pointing out what this is, but I am taking the liberty of backing this patch out of staging and setting it back to review. Without any discoverable purpose and regtest and description and documentation, this just adds dead code that is useless for anybody but the original author.

A patch in that state should remain in the private repository of the author.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]