bug-lilypond
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Issue 1110 in lilypond: Wrong octave of repetition chord with \relat


From: lilypond
Subject: Re: Issue 1110 in lilypond: Wrong octave of repetition chord with \relative and #{ #} syntax
Date: Sun, 29 Jan 2012 01:05:02 +0000


Comment #39 on issue 1110 by address@hidden: Wrong octave of repetition chord with \relative and #{ #} syntax
http://code.google.com/p/lilypond/issues/detail?id=1110

First: I have no idea why git-cl chose to create a new codereview issue for this one-line change.

Second: if you ran patchy first (and thus bounced origin to staging where I pushed preceding changes) I am at a loss at why the patch would not apply. The last upload just now was based "properly" on origin/master. So it should work, even though I don't know what might have gone wrong before.

Since I basically did not leave a line in place, feedback from the original authors of the ChordRepeat stuff would be welcome.

Possible amendments: a repeat chord currently is being distinguishable by having a 'duration property, sort of unobvious. A separate type was infeasible since it needs to turn into a proper EventChord in-place. Since I chose to create my own length callback for EventChord after all, a name like 'chord-repeat-duration might make recognizing a repeat chord more obvious.

The usual docs+regtest+changes missing applies: this is a draft.

It is
 15 files changed, 175 insertions(+), 250 deletions(-)

which is a nice reduction, possible because of issue 2240. Implementing this as far out of the parser/lexer as it now is is another advantage of issue 2240.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]