Re: self-alignment-X has negligible effects on dynamics

[David Nalesnik]

Hi Janek,


On Mon, Jul 28, 2014 at 4:12 PM, Janek Warchoł <address@hidden>
wrote:

> Hi,
>
> 2014-07-28 22:51 GMT+02:00 David Nalesnik <address@hidden>:
> > What is potentially confusing (and you see how badly I've been confused)
> is
> > that the default setting of X-offset has changed.
>
> I'm not sure if i understand.  You mean that default X-offset values
> for DynamicTexts changed, or that DynamicText.X-offset uses a
> different callback now?
>

The default callback has changed.


>
> > I'm used to the old behavior
> >
> > \override DynamicText.X-offset =
> > #ly:self-alignment-interface::x-aligned-on-self
> >
> > gets it back.
>
> It doesn't, actually.  I mean,
>
> {
>   \override DynamicText.X-offset =
> #ly:self-alignment-interface::x-aligned-on-self
>   \override DynamicText.self-alignment-X = #RIGHT
>   c'4\f
>   \override DynamicText.self-alignment-X = #LEFT
>   c'4\f
>   \override DynamicText.self-alignment-X = #CENTER
>   c'4\f
> }
>
> will produce different output before and after my patch.  That's
> because before my patch DynamicTexts' position was calculated from
> x-aligned-on-self AND centered-on-x-parent, in a way that was opaque
> and not configurable by the user.  Of course, it's possible to mimic
> old behaviour.
>
>
Are you referring to that ly:make-simple-closure stuff which was commonly
found in X-offset callbacks?  If so, I don't think this was ever the
setting for DynamicText.X-offset.  At least, in 2.18.2, we have
 (X-offset . ,ly:self-alignment-interface::x-aligned-on-self)
And of course in 2.19.10, we have
(X-offset . ,ly:self-alignment-interface::aligned-on-x-parent)


 > I think that this should be made clear in the documentation, if you
> haven't
> > already done this!
>
> Yes, i should do this (or maybe some doc editor would like to help me?
> I would prefer to focus on making further changes in the code).
>
> best,
> Janek
>
> PS i may not be able to reply again until tomorrow evening (~18 UTC).
> I found that it's harder for me to focus on my day job when i read
> LilyPond email in the morning, especially in case of emotionally
> involving topics like this one.
>

I can imagine. Sorry :(

Best,
David