[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: regression: point-and-click no longer includes absolute path

From: Urs Liska
Subject: Re: regression: point-and-click no longer includes absolute path
Date: Fri, 13 May 2016 09:37:49 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0

Which version of LilyPond and what Linux exactly do you use (2.19.40
binary release?)?

Compiling your example with LilyPond built from current master gives me:

Starting lilypond 2.19.42 [Untitled]...
Processing `/tmp/frescobaldi-dW8ldh/tmpTuF3xf/document.ly'
Success: compilation successfully completed

(and that what was the case when I made that change (and obviously noone
had objections then)).

So please show me what you get in return from that function on your
system. Or an example where point-and-click links are actually generated
relatively and break anything.


Am 13.05.2016 um 09:16 schrieb Mark Knoop:
> The commit below has broken point-and-click links for me on Linux.
> Embedded paths are now relative rather than absolute. It seems the
> assumption in the commit message that an absolute path is always
> returned is incorrect, as can be seen with the following example.
> Reverting scm/output-ps.scm fixes the problem.at
> \version "2.19.40"
> testpaths =
> #(define-void-function
>    (parser location)
>    ()
>    (display (car (ly:input-file-line-char-column location))))
> \testpaths
> commit f30a8189adbbeefa2103e2c2e194040f66bc2291
> Refs: release/2.19.27-1-280-gf30a818
> Author:     Urs Liska <address@hidden>
> AuthorDate: Tue Jan 19 10:52:33 2016 +0100
> Commit:     Urs Liska <address@hidden>
> CommitDate: Sun Jan 24 21:24:52 2016 +0100
>     #4747: Remove (all) uses of is-absolute?
>     The check for absolute paths in  in output-ps.scm
>     and -svg.scm is unnecessary because
>     (car ly:input-file-line-char-column a-location)
>     always returns an absolute, slashified path
>     Now is-absolute? is not used anymore by LilyPond itself.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]