[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bug

From: David Kastrup
Subject: Re: Bug
Date: Mon, 30 Jan 2017 14:22:23 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

Martin Strunz <address@hidden> writes:

> Hi,
> \lily\spanner.cc line 453:
> opposite conditions in nested if statement

Interesting.  I would have thought that something like this most likely
comes about by two different people making patches at different times,
but the whole passage appears to be from

commit a339f8b9865b0f02febd351ba494129d414fb568
Author: Mike Solomon <address@hidden>
Date:   Wed Mar 16 15:07:34 2011 -0400

    Fixes Issue 1504, allowing feather beam line breaking.
    Makes it such that the degree of feathering at the end of a system
    is preserved at the beginning of the next system.
    Adds a normalized-endpoints property to Spanner, which calculates
    the portion of a spanner (normalized from 0 to 1) taken up by any
    broken child.

It is not obvious to me at a cursory reading what the intent here was:
the behavior in the never-reached "if (!orig->is_broken ())" branch is
quite different from the code in the actually taken branch.  So I am
somewhat hesitant in throwing out the code that (right now) is never

Mike?  Any idea what was the intent here and what the correct way to
make it happen would be?

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]