[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: DOC: Correcting spelling of Harmonia Sacra in NR 1.1.4 Shape note he

From: David Kastrup
Subject: Re: DOC: Correcting spelling of Harmonia Sacra in NR 1.1.4 Shape note heads
Date: Sun, 01 Oct 2017 00:46:45 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Karlin High <address@hidden> writes:

> This is a nitpick. The places in the documentation that reference the
> "Harmonia Sacra" songbook by Joseph Funk have the spelling Harmonica
> Sacra. Harmonia does not have a "c" here. A few references are below.
> There are enough of them that a Google search for "Joseph Funk
> Harmonica Sacra" gets auto-corrected.
> http://harmoniasacra.org/index.html
> http://gameo.org/index.php?title=Harmonia_Sacra
> https://www.amazon.com/Harmonia-Sacra-Joseph-Funk/dp/1932676155
> The attached patch has proposed corrections. Translated docs would be
> affected; I do not know the process for that. Possible actions:
> * Forget it. Anyone who would be bothered by this is probably beyond help.
> * Fix directly in git like other typos
> * Go through review and tracker like other patches

I'd use option 2 here (of course, push to staging rather than master)
after carefully reading the diff and making sure that no chapter/node
names are affected (which would constitute a structural change and thus
should be checked doing "make doc" before possibly inconveniencing
others by a broken staging, either by checking yourself or creating an
issue after all).

We have had a fair share of "this could not possibly break compilation"
kind of changes breaking compilation.

Also any possibility for contention is worth a review.  This here seems
solid enough to me.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]