[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Assertion !is_empty() failed - yet again

From: Aaron Hill
Subject: Re: Assertion !is_empty() failed - yet again
Date: Wed, 30 Oct 2019 02:30:49 -0700
User-agent: Roundcube Webmail/1.3.8

On 2019-10-30 2:24 am, Aaron Hill wrote:
On 2019-10-30 2:05 am, Rutger Hofman wrote:
Sincere request: can this assert please be removed? Its validity appears
debatable, and it is a showstopper for me!

If we agree that an empty interval does not have a well-defined
center, then the assertion is quite valid.

But the problematic intervals in question were never intended to ever
be empty, yet their left and right bounds are computed in such a way
to form degenerate, "inside-out" intervals that are treated as empty.
The assertion properly is pointing out this flaw in computation.  As
such, we should not be removing the assertion, because rather we
should ensure that computations never invert the bounds of an

That said, I feel the hard-fail approach of an assertion is too
strong, and what we need is to simply emit a warning that the function
will be returning the midpoint of the interval's bounds despite the
interval appearing to be invalid (read: empty).

I meant to add that such a tactic would not be unprecedented as the codebase already has cases where LilyPond warns it is "crossing its fingers".

-- Aaron Hill

reply via email to

[Prev in Thread] Current Thread [Next in Thread]