[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: glyph-path-regexp in SVG output is overly strict

From: pkx166h
Subject: Re: glyph-path-regexp in SVG output is overly strict
Date: Fri, 21 Feb 2020 13:54:40 +0000
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2


On 21/02/2020 11:54, Jonas Hahnfeld wrote:
Am Freitag, den 21.02.2020, 11:50 +0000 schrieb pkx166h:

On 21/02/2020 11:33, Simon Tatham wrote:
Jonas Hahnfeld <
looking at
the grammar you linked, I think the regular expression is also missing
'+Aa,'. Does it make sense to fuse attached patch?
The idea looks sensible to me, but I think you've made a mistake in the
regular expression syntax. The character '-' has to appear immediately
after the open bracket, otherwise it's taken to be the punctuation in a
range such as "A-Z". So the character class
[+-MmZzLlHhVvCcSsQqTtAa0-9,.Ee\n ] will match (at least) any character
between '+' and 'M'.

If you start the brackets with [-+Mm...] instead of [+-Mm...] then I
think it does what you intended.

I am not sure if this will update the tracker as Simon would have to
have the correct rights (he only contributes occasionally like this so
probably won't be interested in general LP development) the point is
that I may have to cut/paste his reply into the tracker if this is the
case so others can follow.
It probably won't... If you don't mind, I'll carry the two commits over
to Rietveld so we can go through the review cycle and copy Simon's
reply (which is fully correct!) to SF. Ok?

Be my guest.

It'd take some load off of me and you can talk to Simon in a language he will understand.

I did a quick test with Simon's patch (I didn't configure my work machine to upload using git-cl so I have no rietveld only the tracker) and it did pass all tests.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]