[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: SVG style and contributing barrier to entry
From: |
Jonas Hahnfeld |
Subject: |
Re: SVG style and contributing barrier to entry |
Date: |
Thu, 16 Apr 2020 11:13:25 +0200 |
User-agent: |
Evolution 3.36.1 |
Am Donnerstag, den 16.04.2020, 05:00 -0400 schrieb Patrice Levesque:
> Hi!
>
> I just discovered that the “style” tag created inside svg output uses the
> wrong syntax, e.g.
>
> <style text="style/css">
> Should be:
>
> <style type="text/css">
> Reference: https://www.w3.org/TR/SVG/styling.html#StyleElement
>
> A trivial one-line patch to fix this (based on git master):
>
> diff --git a/scm/framework-svg.scm b/scm/framework-svg.scm
> index 0abb430fe3..07d4d9e3ec 100644
> --- a/scm/framework-svg.scm
> +++ b/scm/framework-svg.scm
> @@ -56,7 +56,7 @@
> `(viewBox . ,(ly:format "~4f ~4f ~4f ~4f"
> (third rest) (fourth rest)
> (fifth rest) (sixth rest))))
> - (eo 'style #t '(text . "style/css"))
> + (eo 'style #t '(type . "text/css"))
> "<![CDATA[
> tspan { white-space: pre; }
> "))
> Wanting to submit this patch, I've looked at the LilyPond Contributor's
> guide¹, and frankly, I'm amazed by the height of the barrier to entry:
>
> I'd have to sign up with Google (surprising for a GNU project) and create an
> account there, with all the privacy implications that goes with it.
>
> I'd have to create a Sourceforge account, then send an e-mail to a human
> to ask for write permission to the bug tracker.
>
> I'd have to install a tool (git-cl), then configure the Sourceforge account
> to grant that tool access, then configure git-cl.
>
> I don't expect to become a LilyPond developer in this lifetime, so the above
> represents an investment I'm not willing to make.
Agreed that this is a huge barrier to submit easy patches. Hopefully
this can be improved in the future...
> The other option — subscribe to yet another mailing list (bug-lilypond) that
> I'll need to use for a very limited time span and that will spam me with bug
> reports I don't care about until I unsubscribe — feels awkward to me.
As far as I understand, you don't need to subscribe in order to post
there. In any case, I'm subscribed so I'll cross-post and CC James so
that the patch (which looks correct to me) is not lost.
Thanks
Jonas
signature.asc
Description: This is a digitally signed message part
- Re: SVG style and contributing barrier to entry,
Jonas Hahnfeld <=