bug-m4
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: Fix 198.sysval


From: fink
Subject: Re: [PATCH] tests: Fix 198.sysval
Date: Wed, 2 Jun 2021 05:01:36 -0500
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.10.2

On 6/1/21 8:16 AM, Eric Blake wrote:
In my attempt to avoid test failures on Haiku, I caused test failures
on platforms where sh is noisy when reporting a killed sub-process.

* doc/m4.texi (Sysval): Avoid stderr noise during test.
Fixes: 17011ea76a (tests: Skip signal detection on Haiku)
Fixes: https://lists.gnu.org/archive/html/bug-m4/2021-05/msg00029.html
---
  doc/m4.texi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/m4.texi b/doc/m4.texi
index 247f2be5..3b833b2a 100644
--- a/doc/m4.texi
+++ b/doc/m4.texi
@@ -6756,7 +6756,7 @@ Sysval
  ')m4exit(`77')')dnl
  changequote(`[', `]')
  @result{}
-syscmd([/bin/sh -c 'kill -9 $$'; st=$?;
+syscmd([@{ /bin/sh -c 'kill -9 $$'; @} 2>/dev/null; st=$?;
  test $st = 137 || test $st = 265])
  @result{}
  ifelse(sysval, [0], , [errprint([ skipping: shell does not send signal 9

Confirming that patching the 1.4.19 tarball with commits a1354086 and cd7f4d15 makes 198.sysval pass on macOS. Thank you,

```
Checking ./197.sysval
Checking ./198.sysval
Checking ./199.mkstemp
```

Hanspeter



reply via email to

[Prev in Thread] Current Thread [Next in Thread]