bug-mailutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mail duplication


From: Sergey Poznyakoff
Subject: Re: mail duplication
Date: Fri, 27 Jul 2001 13:07:05 +0300

Bonjour,

>   I would advocate :
> - to nuke mail/util.c(util_{malloc,calloc}) for xmalloc() and xcalloc()
> it comes by default part of libmailutils/xmalloc.c

Done. I also changed xalloc_die() to call mu_error() instead of error().

> - I see a lot of code duplications in mail/*, for some I'll take the
> blame 8-).

Yes, it needs a good revision.
 
By the way, how about Sam's proposition to update TODO entries? At
least this entry:

  [mail]
  - clean up 'mail''s compilation, why is there a mail script?

seems completely out of date. I would propose to modify it as follows:

Index: TODO
===================================================================
RCS file: /cvs/mailutils/TODO,v
retrieving revision 1.11
diff -p -u -w -b -r1.11 TODO
--- TODO        2001/07/13 02:28:02     1.11
+++ TODO        2001/07/27 10:02:12
@@ -3,9 +3,10 @@
 = --> on hold
 * --> in progress
 
+
 [libmailbox]
 
-* autogen.sh (libtool) complains about libmailbox.la in noinst (JB Oct 08/99)
++ autogen.sh (libtool) complains about libmailbox.la in noinst (JB Oct 08/99)
 
 - added more includes, make sure autoconf finds them
 
@@ -24,18 +25,13 @@
 
 * Maildir is VERY rough
   
-[mail]
-
-- clean up 'mail''s compilation, why is there a mail script?
-
 [pop3]
-
-- find out why the pop3 server quits on a signal when the 'quit' command is
++ find out why the pop3 server quits on a signal when the 'quit' command is
   given
 
-- test daemon code
++ test daemon code
 
-- test network code
++ test network code
 
 + crypt is linked even if pam was detected, it should be one or the other (JB 
Oct 08/99)
 

-Sergey





reply via email to

[Prev in Thread] Current Thread [Next in Thread]