Re: [bug-mailutils] Sieve bugs [mailutils 1.0]

[Sergey Poznyakoff]

Kostas Zorbadelos <address@hidden> wrote:

> The attached patch solves the issue.

Shouldn't it rather be:

Index: libsieve/extensions/vacation.c
===================================================================
RCS file: /cvsroot/mailutils/mailutils/libsieve/extensions/vacation.c,v
retrieving revision 1.14
diff -p -u -r1.14 vacation.c
--- libsieve/extensions/vacation.c      27 Jun 2006 13:07:56 -0000      1.14
+++ libsieve/extensions/vacation.c      3 Oct 2006 16:37:50 -0000
@@ -448,7 +448,9 @@ vacation_subject (mu_sieve_machine_t mac
       
       free (value);
     }
-
+  else
+    subject = "Re:";
+    
   if (mu_rfc2047_encode (MU_SIEVE_CHARSET, "quoted-printable",
                         subject, &value))
     mu_header_set_value (newhdr, MU_HEADER_SUBJECT, subject, 0);


??
      
> The second bug is in the sieve parser.

Here's the patch:
 
Index: libsieve/prog.c
===================================================================
RCS file: /cvsroot/mailutils/mailutils/libsieve/prog.c,v
retrieving revision 1.16
diff -p -u -r1.16 prog.c
--- libsieve/prog.c     27 Jun 2006 13:07:56 -0000      1.16
+++ libsieve/prog.c     3 Oct 2006 16:37:48 -0000
@@ -194,6 +194,14 @@ sieve_code_command (mu_sieve_register_t 
              if (tag->argtype != SVT_VOID)
                {
                  mu_iterator_next (itr);
+                 if (mu_iterator_is_done (itr))
+                   {
+                     sieve_compile_error (sieve_filename, sieve_line_num,
+                          _("required argument for tag %s is missing"),
+                                          tag->name);
+                     err = 1;
+                     break;
+                   }
                  mu_iterator_current (itr, (void **)&tagrec.arg);
                }
              else

Thanks for reporting.

Regards,
Sergey