bug-make
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: source file extension


From: Duke Normandin
Subject: RE: source file extension
Date: Wed, 20 Oct 2010 18:33:58 -0600 (MDT)
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)

On Wed, 20 Oct 2010, Martin Dorey wrote:

> > define assert
> > $(call assert,$($ARGS), The variable "$ARGS" is null)
> > endef
>
> This code is dead - nothing calls it.  I see that it includes an
> expression that will be evaluated (if it's ever called) as $(A)RGS
> when it was probably intended to say $(ARGS).
> > SRCS = $(wordlist 2, 999, $(ARGS))
>
> What sets ARGS?  Not make:
>
> address@hidden:/tmp$ make -f badger.make -p 2>&1 | grep ARGS
> address@hidden:/tmp$

ARGS is set at the CLI, like:

make ARGS="test test.mod"

> Putting spaces after commas helps readability but it's generally a
> bad idea in makefiles.  It's semantically significant:
> address@hidden:/tmp$ cat > badger.make
> SRCS := $(subst a, b, bac)
> address@hidden:/tmp$ make -f badger.make -p 2>&1 | grep SRCS
> SRCS :=  b bc
> address@hidden:/tmp$
>
> > $(EXEC-FILE): $(SRCS:%.o=%.mod)
> > # $(LINK) $@ $^                                                             
> >                      $(LINK) $^ -o $@

>  The first line after the colon must start with a tab.  Perhaps it
> does already but something bad happened to that rule, perhaps in
> transit, likely from my mail client (sorry).

There's a TAB in my Makefile. Like my original post says - this
Makefile _works very well_ with the Oberon compiler.

> Now, sigh, this is going to sound patronising, for which I
> apologize, but hopefully you'll appreciate that more than just going
> silent on you:
> Bug reports should show what you typed and what the computer
> displayed.  It would also be a good idea to include which version of
> make you're using and ideally on which platform.  This mailing list
> is really for bugs in Make itself, not for bugs in makefiles.  I
> believe there's a help-make list for that.

OK! help-make list it will be. Thanks.
-- 
Duke



reply via email to

[Prev in Thread] Current Thread [Next in Thread]