[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: patch to support output synchronization under -j

From: David Boyce
Subject: Re: patch to support output synchronization under -j
Date: Thu, 14 Apr 2011 14:12:16 -0400

On Thu, Apr 14, 2011 at 1:48 PM, Eli Zaretskii <address@hidden> wrote:
> David, can you explain why you needed to lock the files?  Also, what
> region(s) of the file you are locking?  fcntl with F_WRLCK won't work
> on Windows, so the question is how to emulate it.

I was about to write this up but I see Paul beat me to it ...

> Finally, I'd suggest that the system-dependent portions of sync_output
> be factored out into a separate function, so that the Windows port
> could have its own implementation without infesting job.c with yet
> another bunch of #ifdef's.

Agree. Ifdef bad. Just wanted to see if the feature would be favorably
looked on first. I can't actually do the Windows etc ports but I could
certainly refactor it with stubs.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]