[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug #41813] Mult-line override define failing on VMS.

From: John E. Malmberg
Subject: Re: [bug #41813] Mult-line override define failing on VMS.
Date: Sun, 16 Mar 2014 21:31:00 -0500
User-agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:17.0) Gecko/20130215 Thunderbird/17.0.3

On 3/16/2014 6:35 PM, John E. Malmberg wrote:
On 3/16/2014 4:13 PM, h.becker wrote:
Appended is a temporary fix for the multiline problem.

As I mentioned in the make recursion thread:

I changed from the wrapper code to code that sets the makefile name, and
temporarily set a local symbol as a foreign command.  At exit the symbol
is either deleted or replaced with the original value, which leaves
argv[0] alone.

I also found that the vms_exit() code had a bug in it, because it was
written with the expectation of getting a UNIX exit status, and GNU make
is passing it VMS exit statuses.

As only codes 0, 1, 2 are defined for GNU make status, and the lowest
failure status from VMS is 8, for GNU make, the conversion to VMS status
should only be done for codes 1-7, the rest should be passed through.

EAGLE> del lcl_root:[...]*.*;*/exc=(*.dir,*.pm)
EAGLE> perl run_make_tests.pl features/override

                       Running tests for GNU make on VMS
                                GNU Make 4.0.90

Clearing /lcl_root/make/tests/work...
Making work dirs...

features/override ....................................... ok     (4 passed)

The archive tests are also now all passing.

Missed one thing on the vms_exit fixes, and it was causing some tests to look like they passed instead of failing.

The archive tests are now failing again and so is the override test with out your fix. Will try your fix next.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]