[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Q: On Windows why not ignore CRLF?

From: Paul Smith
Subject: Re: Q: On Windows why not ignore CRLF?
Date: Fri, 02 Jun 2017 15:56:51 -0400

On Thu, 2017-06-01 at 17:41 +0300, Eli Zaretskii wrote:
> > I'm not sure about this implementation (performance-wise) but
> > leaving
> > that aside, I don't understand why this code is ifdef'd out on
> > Windows. 
> Well, it's your code, or so it seems ;-)  And it was always ifdef'ed
> away on those platforms, since the day it was committed back in 1999
> (see commit 7052a57).

I expect I just did it so that I didn't change the Windows behavior in
any way, since at the time I didn't do anything with Windows (not even
build there) and I wasn't sure if this was right or not for that

On Thu, 2017-06-01 at 17:41 +0300, Eli Zaretskii wrote:
> I think Ray is right: the CRLF combination simply cannot happen on
> those platforms, because Make there uses text-mode reads, so the CR
> characters are simply gone by the time we get here.

OK maybe I'm misunderstanding the cause of the test difference I see. 
I'll look more closely.

FYI, I don't know how "good" this is for testing requirements but on my
Windows systems I've installed Git for Windows (along with Perl of
course) and that provides a number of UNIX commands which is why I
think many of the tests work even though the recipes use lots of UNIX
code.  Also I have no idea what the shell settings are during these
tests; maybe it finds the Git for Windows sh and uses that.

I guess it's better than what we had before :).

There's so much that needs to be done to improve the test framework in
general: portability is just one (big) chunk of that.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]