[bug #54429] make can block after being killed (3)

[Koen Van Hoof]

URL:
  <http://savannah.gnu.org/bugs/?54429>

                 Summary: make can block after being killed (3)
                 Project: make
            Submitted by: kvho
            Submitted on: Thu 02 Aug 2018 01:29:19 PM CEST
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
       Component Version: None
        Operating System: None
           Fixed Release: None
           Triage Status: None

    _______________________________________________________

Details:

I got into following callstack :
fatal_error_signal
  reap_children (1, 0)
    pfatal_with_name ("wait")
      OSS (fatal, NILF, _("%s: %s"), name, err)
        die (MAKE_FAILURE)
          reap_children (1, err)
This did block because both reap_children do decrement job_slots_used

Solution :

void
die (int status)
{
  static char dying = 0;

  if (!dying && !handling_fatal_signal)
    {

...




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?54429>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/