Re: [PATCH] guix: mescc-tools: Update to 0.7.0, adding ARM support.

[Jan Nieuwenhuizen]

Danny Milosavljevic writes:

Hi Danny,

> On Tue,  9 Jun 2020 19:24:19 +0200
> Danny Milosavljevic <dannym@scratchpost.org> wrote:
>
>>       `(#:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs 
>> "out"))
>>                            "CC=gcc")
>
> Hmm, cross-compilation probably doesn't work as expected with CC=gcc, right?

Certainly not...good catch!

> Also, isn't the default CC=gcc in there anyway?

Nope, removing that line gives

--8<---------------cut here---------------start------------->8---
$ GUIX_PACKAGE_PATH=guix guix build mescc-tools
[..]
make: cc: No such file or directory
make: *** [makefile:27: M1] Error 127
command "make" "-j" "8" 
"PREFIX=/gnu/store/6fq9irc34nwjd3p708b5wqpdijma87i8-mescc-tools-0.7.0" failed 
with status 2
builder for `/gnu/store/knbysmv4gvsddv4720lg5qz2xjfrkpp6-mescc-tools-0.7.0.drv' 
failed with exit code 1
@ build-failed 
/gnu/store/knbysmv4gvsddv4720lg5qz2xjfrkpp6-mescc-tools-0.7.0.drv - 1 builder 
for `/gnu/store/knbysmv4gvsddv4720lg5qz2xjfrkpp6-mescc-tools-0.7.0.drv' failed 
with exit code 1
--8<---------------cut here---------------end--------------->8---

> Nowadays Guix has
>
> (define* (cc-for-target #:optional (target (%current-target-system)))
>   (if target
>       (string-append target "-gcc")
>       "gcc"))

Right.

> Otherwise LGTM!

Thanks, pushed to master with these modifications as 
40aa19045902fb8942a3295920b470715850e91e

I also pushed an update to dir-locals.el to avoid messing-up indentation
while editing the packages.

Janneke

-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com