bug-parted
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-parted] parted 1.3.x errata


From: Damien Genet
Subject: [Bug-parted] parted 1.3.x errata
Date: Fri, 17 Mar 2000 16:34:45 +0100

Salut,

ped_disk_get_max_partition_geometry() is defined two time in disk.h

In msdos_partition_is_flag_available(),
DosPartitionData*  dos_data isn't use,
you should also remove PED_ASSERTs
the func should, maybe, return true to PED_PARTITION_HIDDEN
only for FAT, and false for PED_PARTITION_BOOT when
partition is extended.

In the same way, in msdos_partition_set_flag() may fail
when you want to hide a non FAT partition

I'll modify all this if you agree.

Is it possible to know what flags would be available before creating
a partition?
Maybe should modify *_partition_is_flag_available()
so arguments would be a PedFileSystemType and a 
PedPartitionType instead of the PedPartition argument that does not
seems to be used in other *_partition_is_flag_available(),
or maybe should add a new function?


Thanks,
Dam





reply via email to

[Prev in Thread] Current Thread [Next in Thread]