[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

GPT patch against 1.4.15-pre1

From: Matt_Domsch
Subject: GPT patch against 1.4.15-pre1
Date: Thu, 28 Jun 2001 17:54:25 -0500

Andrew, I've provided a patch agaist 1.4.15-pre1 that adds GPT support.  As
requested, it is a lot cleaner.  ped_free(), endianness (best as I can tell,
as I don't have any bigendian hardware to test on), functions renamed to use
lower case, use ped_device_{read,write}, etc.

Thanks also to Bill Nottingham for a couple patches.  This now probes the
file system so you see "ext2" show up when you do a print. :-)  Also, the
crc32 function name clashed with a similar name in zlib, which caused some

A couple other changes to code not mine:
* Several of the file systems had #include <asm/page.h> which isn't
necessary on IA-32, nor proper (on IA-64 it fails miserably).
* in libparted, a pointer was getting cast to (int) rather than (long).
* a couple other "set pointer to NULL at initialization" things.

One issue remains on IA-64.  If -Werror is used when compiling, it complains
that unsigned long long int is used as a printf format specifier (%llx) when
the arg is uint64_t.  I'd argue that the compiler is wrong on this error, as
long long int is 64-bits on both IA-32 and IA-64.  Building without -Werror
doesn't cause this failure.

It's available on

As always, I appreciate comments on how to make this better.


Matt Domsch
Sr. Software Engineer
Dell Linux Solutions
#2 Linux Server provider with 17% in the US and 14% Worldwide (IDC)!
#3 Unix provider with 18% in the US (Dataquest)!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]