[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] canonicalize_file_name

From: Andrew Clausen
Subject: Re: [patch] canonicalize_file_name
Date: Wed, 15 Aug 2001 21:58:34 +1000
User-agent: Mutt/1.2.5i

On Tue, Aug 14, 2001 at 10:34:55AM +0200, Neal H Walfield wrote:
> In libparted/device.c, we were using a home brewed hack to canonicalize
> a file name (i.e. expand symbolic links, remove superfuous path
> components, etc.).  This is unnecessary as libc already has the
> functionality to do this for us.

Oops, I couldn't find one in libc.

> -static PedDevice*    devices = NULL;
> +static PedDevice*    devices;

I'm not applying that, until I get a legal guarantee (*grin*) that
this is safe.  Why don't the gcc ppl just put this in zero memory,
if they know it's zero?  This is a gcc bug, as far as I'm concerned.

Apart from that, all looks good.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]