Re: DevFS and Partition Table Resync (PATCH)

[Hong H. Pham]

Hi Andrew,

> Thanks for the patch.  Just some nitpicks about the patch:

Oooooo... my bad.  Nevertheless, I appreciate your criticisms.

> Is there any reason why kernel problems shouldn't be fixed, as opposed
> to complicating parted?
>
> > The work around for this is to check if DevFS is active, and if so,
> > _disk_sync_part_table() calls _kernel_reread_part_table() rather than
> > trying to resync the partition table.
>
> which is really a non-solution, because that doesn't work if there
> are any partitions mounted / swapped on whatever (true 99% of the
> time).  So, you gain nothing.

Right, the real fix should be in the kernel.  However, have it work in the
case where no partitions are in use is better than not having it work at
all.  I'll drop a mail to the DevFS folks regarding the BLKPG_* ioctl
calls not updating devfs shortly.

> Anyway, I've applied it with my own cleanups.
> You should probably be signing a disclaimer, because you have made
> a few small changes now... is this ok?  (feel free to discuss privately)

Sounds good with me, as long as I don't have to sign my soul away ;)

Cheers!
..hong