[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] DOS #defines (was Re: Parted 1.6.0-pre3)

From: Andrew Clausen
Subject: Re: [PATCH] DOS #defines (was Re: Parted 1.6.0-pre3)
Date: Mon, 4 Mar 2002 22:36:24 +1100
User-agent: Mutt/1.3.17i

On Mon, Mar 04, 2002 at 12:44:58AM -0700, Andreas Dilger wrote:
> This patch replaces the use of numerical partition types in DOS partitions
> with #defined names (it could be an enum, I suppose, also).  This makes it
> a bit cleaner code I think (especially w.r.t. hidden partitions).

Thanks... I think I already received this patch from you, just
I hadn't gotten around to commenting yet.

Anyway, the code used to look like this, just I thought it was
ugly, since the code was basically looking like case statements
anyway.  (And, the numbers where never "magic" because of the
context, etc.)

However, the structure isn't really like a case statement,
because of all the flags stuff (which I also haven't commented
on yet, sorry... I'm getting there!)

Anyway, I'm convinced ;)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]