Re: [Fwd: Bug#196085: Device files are not accepted under the Hurd]

[Andrew Clausen]

Hi all,

Thanks.  I just applied the patch (which you can't see yet... no CVS ):
Sorry for the delay.  Exams are finished for this semester :)

Cheers,
Andrew


On Thu, Jun 05, 2003 at 08:10:47AM +1000, Timshel Knoll wrote:
> 
> -- 

Content-Description: Forwarded message - Bug#196085: Device files are not 
accepted under the Hurd
> X-Original-To: address@hidden
> Subject: Bug#196085: Device files are not accepted under the Hurd
> Reply-To: Ognyan Kulev <address@hidden>, address@hidden
> Resent-From: Ognyan Kulev <address@hidden>
> Resent-To: address@hidden
> Resent-Cc: address@hidden, Timshel Knoll <address@hidden>
> Resent-Date: Wed, 04 Jun 2003 14:03:10 UTC
> Resent-Message-ID: <address@hidden>
> X-Debian-PR-Message: report 196085
> X-Debian-PR-Package: parted
> X-Debian-PR-Keywords: patch upstream
> From: Ognyan Kulev <address@hidden>
> To: address@hidden
> Organization: Faculty of Mathematics and Informatics
> Resent-Sender: Debian BTS <address@hidden>
> X-Spam-Status: No, hits=-8.6 required=5.0
>       tests=BAYES_01,DEBIAN_BTS_BUG,PATCH_UNIFIED_DIFF,
>       USER_AGENT_MOZILLA_UA,X_LOOP version=2.55
> X-Spam-Level: 
> X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
> 
> Package: parted
> Version: 1.6.5-1
> Severity: important
> Tags: patch, upstream
> 
> Under the Hurd, when device file is passed as an argument to "parted",
> Segmentation fault occurs.  More detailed report can be found in
> http://mail.gnu.org/archive/html/bug-hurd/2002-10/msg00036.html
> 
> The reason is using store_typed_open instead of store_open.  More
> information can be found in $HURD/libstore/store.h (or
> /include/hurd/store.h).  Basicly, store_typed_open expects something
> like "device:hd0", while store_open expects something like "/dev/hd0".
> Needless to say, the latter is what everyone would try.  The first style
> is equivalent of (MAJOR,MINOR) pair in *nix, and the second style is
> equivalent of block device file name.
> 
> I forward this bug report to bug-hurd, as I'm not completly sure if this
> is the right fix.
> 
> Regards
> -- 
> Ognyan Kulev <address@hidden>, "\"Programmer\""
> 7D9F 66E6 68B7 A62B 0FCF  EB04 80BF 3A8C A252 9782
> 

> --- parted-1.6.5.orig/libparted/gnu.c
> +++ parted-1.6.5/libparted/gnu.c
> @@ -235,12 +235,12 @@
>         arch_specific->consume = 1;
>   
>   retry_open:
> -       err = store_typed_open (dev->path, 0, NULL, &arch_specific->store);
> +       err = store_open (dev->path, 0, NULL, &arch_specific->store);
>         if (err) {
>                 error_t rw_err = err;
>   
> -               err = store_typed_open (dev->path, STORE_READONLY, NULL,
> -                                       &arch_specific->store);
> +               err = store_open (dev->path, STORE_READONLY, NULL,
> +                                 &arch_specific->store);
>                 if (err) {
>                         if (ped_exception_throw (
>                                 PED_EXCEPTION_ERROR,