[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Fwd: Bug#207634: parted needs some data structure padding on m68k.]

From: Timshel Knoll
Subject: [Fwd: Bug#207634: parted needs some data structure padding on m68k.]
Date: Fri, 29 Aug 2003 23:59:00 +1000

Another bug with included patch.



Timshel Knoll
Debian GNU/Linux Developer      http://www.debian.org/
SPI Contributing Member         http://www.spi-inc.org/
GnuPG:          1024D/DE3E8AA7 Timshel Knoll <address@hidden>
Fingerprint:    6ABC 91A9 E274 ED67 0E32  8F0F 5DFA 9391 DE3E 8AA7
--- Begin Message --- Subject: Bug#207634: parted needs some data structure padding on m68k. Date: Thu, 28 Aug 2003 14:07:08 +0200
Package: parted
Version: 1.6.5-2
Severity: important
Tags: patch


Here is a patch originating from Roman Zippel that adds propper m68k-friendly
padding to two parted filesystems supports. Notice that maybe adding a packed
attribute would be good also, but this is not implemented here. Upstream
already know of this problem, and it will probably be fixed in the next
upstream release (that is, the one after 1.6.6 when it ever is ressurected
after the gnu ftp server intrussion).

If need be, i can make an NMU for this.

diff -Nur parted-1.6.5.org/libparted/fs_reiserfs/reiserfs.h 
--- parted-1.6.5.org/libparted/fs_reiserfs/reiserfs.h   2002-08-10 
02:47:33.000000000 +0200
+++ parted-1.6.5/libparted/fs_reiserfs/reiserfs.h       2003-08-23 
14:20:21.000000000 +0200
@@ -50,7 +50,7 @@
     uint16_t s_tree_height;
     uint16_t s_bmap_nr;
     uint16_t s_version;
-    char padding[436];
+    char padding[438];
 typedef struct reiserfs_super_block reiserfs_super_block_t;
diff -Nur parted-1.6.5.org/libparted/fs_ufs/ufs.c 
--- parted-1.6.5.org/libparted/fs_ufs/ufs.c     2002-04-10 03:53:21.000000000 
+++ parted-1.6.5/libparted/fs_ufs/ufs.c 2003-08-23 14:20:33.000000000 +0200
@@ -169,7 +169,7 @@
        int32_t fs_postbloff;           /* (__s16) rotation block list head */
        int32_t fs_rotbloff;            /* (uint8_t) blocks for each rotation */
        int32_t fs_magic;               /* magic number */
-       uint8_t fs_space[1];            /* list of blocks for each rotation */
+       uint8_t fs_space[4];            /* list of blocks for each rotation */
 static PedGeometry*

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux iliana 2.4.21 #2 SMP jeu aoĆ» 14 13:48:07 CEST 2003 i686
Locale: LANG=fr_FR.ISO-8859-1, LC_CTYPE=fr_FR.ISO-8859-1

Versions of packages parted depends on:
ii  libc6         2.3.2-3                    GNU C Library: Shared libraries an
ii  libncurses5   5.3.20030719-1             Shared libraries for terminal hand
ii  libparted1.6- 1.6.5-2                    The GNU Parted disk partitioning s
ii  libreadline4  4.3-5                      GNU readline and history libraries
ii  libuuid1      1.34+1.35-WIP-2003.08.21-2 Universally unique id library

-- no debconf information

Attachment: /tmp/m68K_fix.diff
Description: Text Data

--- End Message ---

Attachment: signature.asc
Description: This is a digitally signed message part

reply via email to

[Prev in Thread] Current Thread [Next in Thread]