Re: HFS Patch 15 out

[Andrew Clausen]

On Tue, Oct 05, 2004 at 02:42:35PM +0200, Szakacsits Szabolcs wrote:
> Nowadays BLKFLSBUF is useless, it doesn't do anything (should flush and
> invalidate buffers). To be honest, I even can't guess why parted uses it
> instead of sync. It just seems wrong.

Parted does both.  Is it safe to just do fsync()?

> > on every umounted partitions of the disk, and that take (umount test
> > and ioctl) an amount of time that is just too high for my high use of
> > syncs.
> 
> Umount test? Ouch. Every partitions? Ouch again. I can't get this part
> either. Perheps you're using a wrong API?

This is right... the code before HFS+ doesn't need to call sync() much,
so it got overlooked.

You need this because you can get cache-coherency problems between
partition and whole-disk devices.

There clearly needs to be two API calls... one paranoid and one
for resizers that know they are the only ones accessing the disk.

Cheers,
Andrew