Re: Removing "pointless" exception for exotic block devices causes probe to find CDs

[Andrew Clausen]

On Sat, Dec 04, 2004 at 10:40:52AM +0000, Colin Watson wrote:
> +2004-11-21  Andrew Clausen <address@hidden>
> +* libparted/linux.c (linux_new): get rid of pointless exception for
> +  exotic block devices.
> 
> -       if (ioctl (arch_specific->fd, HDIO_GETGEO, &geometry)) {
> -               ped_exception_throw (PED_EXCEPTION_ERROR,
> -                                    PED_EXCEPTION_CANCEL,
> -                                    _("Could not read geometry of %s - %s."),
> -                                    dev->path, strerror (errno));
> -               goto error;
> -       }
> 
> This causes ped_device_probe_all() to find CD drives, which causes the
> Debian installer's partition manager to offer CD drives for
> partitioning, which of course is not terribly useful and makes the UI
> very confusing. I suspect the same applies to other parted frontends.
> Can this change be backed out?

I would rather we had some other mechanism for detecting CD drives
and other read-only media.  Clearly, the CD thing is purely a
side-effect.

Cheers,
Andrew