RE: FW: Publish the changes

[Jen, Janet (Windows IPF Engineer)]

Leslie,
  Any feedback on the review? We are hoping to wrap up the process by
August 26 to be ready for the release. Please let us know if anything
else we need to do here.

  Janet

Janet Jen
WIE program manager
(408) 447-3251

-----Original Message-----
From: Timmers, Rogerio 
Sent: Tuesday, August 02, 2005 1:51 PM
To: 'address@hidden'
Cc: 'Parted Mailing List'; Lau, Mel; Jen, Janet (Windows IPF Engineer);
Timmers, Rogerio
Subject: RE: FW: Publish the changes

 
Hi Leslie, 

Here is the diff file with the changes.
Please let me know if you have any questions.

Thanks,
_______________________________________
Rogerio Timmers
HP Brazil
+1 55 51 2121-3547
TN: 725-3547

-----Original Message-----
From: Jen, Janet (Windows IPF Engineer) 
Sent: Tuesday, July 26, 2005 19:42
To: address@hidden
Cc: Parted Mailing List; Timmers, Rogerio; Lau, Mel
Subject: RE: FW: Publish the changes

Leslie,
  Rogerio Timmers is going to take care of the requirements. We are
going to release our product which uses the new PARTED changes by end of
August. We will need to finish the whole process before then.

  Janet

Janet Jen
WIE program manager
(408) 447-3251
-----Original Message-----
From: address@hidden [mailto:address@hidden
Sent: Tuesday, July 26, 2005 3:21 PM
To: Jen, Janet (Windows IPF Engineer)
Cc: Parted Mailing List
Subject: Re: FW: Publish the changes

On Tue, Jul 26, 2005 at 02:00:18PM -0700, Jen, Janet (Windows IPF
Engineer) wrote:
>    We are making the changes and will send the file when it is done.
>    Are there any other changes that need to be made?
Please create all patches against current CVS. The changes in disk.c,
for example, have an offset of about 70 lines, which is too much fuzz
for the patch utility -- we'd have to fix that by hand.
So please update the patch against current CVS instead of Parted 1.6.22.


> @@ -514,8 +521,14 @@
>                                            (uint16_t)
pte->PartitionName[i]);
>         gpt_part_data->name[i] = 0;
> 
> -       gpt_part_data->lvm = gpt_part_data->raid = gpt_part_data->boot
> -               = gpt_part_data->hp_service = 0;
> +       gpt_part_data->lvm = gpt_part_data->raid = 
> +               gpt_part_data->boot = gpt_part_data->hp_service = 
> +                       gpt_part_data->hidden = gpt_part_data->msftres

> + = 0;
> +
Move the equals relation to the beginning of the succeeding line and
stay at one tab indent.


I had a quick look at the rest and did not find any problems, but I'll
take a second and closer look later.


> If the code looks fine, what is the next step for us?
When the patch is accepted it will be committed to CVS.
You can get it from the repository then or wait for Parted 1.6.24.

Regards,

Leslie

--
PGP-KID: 0x52D70289