[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: memory leak in gpt.c (Fixed the correct way)
From: |
Håkon Løvdal |
Subject: |
Re: memory leak in gpt.c (Fixed the correct way) |
Date: |
Mon, 26 Dec 2005 17:19:20 +0100 |
On 12/26/05, Harley D. Eades III <address@hidden> wrote:
> +static void
> +pth_free (GuidPartitionTableHeader_t* pth) {
> + if (pth->Reserved2)
> + ped_free (pth->Reserved2);
> +
> + if (pth)
> + ped_free (pth);
> +}
There is no point in the last "if (pth)" test; if pth is NULL the
program will crash
at the pth->Reserved2 reference. On the question of whether passing NULL
to a function like this should be valid or not I tend to think it
should not, and therefore
suggest adding PED_ASSERT(pth != NULL, return) at the beginning.
BR Håkon Løvdal
- memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/23
- Re: memory leak in gpt.c (Fixed the correct way), Patrick Leslie Polzer, 2005/12/23
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/23
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Patrick Leslie Polzer, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way),
Håkon Løvdal <=
- Re: memory leak in gpt.c (Fixed the correct way), Patrick Leslie Polzer, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Patrick Leslie Polzer, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Otavio Salvador, 2005/12/26
- Re: memory leak in gpt.c (Fixed the correct way), Harley D. Eades III, 2005/12/26