Re: memory leak in gpt.c (Fixed the correct way)

[Harley D. Eades III]

On Mon, 2005-12-26 at 17:19 +0100, Håkon Løvdal wrote:
> On 12/26/05, Harley D. Eades III <address@hidden> wrote:
> > +static void
> > +pth_free (GuidPartitionTableHeader_t* pth) {
> > +       if (pth->Reserved2)
> > +               ped_free (pth->Reserved2);
> > +
> > +       if (pth)
> > +               ped_free (pth);
> > +}
> 
> There is no point in the last "if (pth)" test; if pth is NULL the
> program will crash
That is the point we don't want to crash. 

> at the pth->Reserved2 reference. On the question of whether passing NULL
> to a function like this should be valid or not I tend to think it
> should not, and therefore
> suggest adding PED_ASSERT(pth != NULL, return) at the beginning.
What is the difference between what I have and a PED_ASSERT? All the
PED_ASSERT will do is return if pth is NULL, right?  The function as is
will not free anything unless there is memory, which is in my mind
correct.

-- Harley 
-----BEGIN GEEK CODE BLOCK-----
G: GCS-- d- a? C++++ B- E+++ W+++ N++ w--- X+++ b++ G e* r x+ z+++++
------END GEEK CODE BLOCK------