[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Wrong logical sector size detection
From: |
leslie . polzer |
Subject: |
Re: Wrong logical sector size detection |
Date: |
Thu, 6 Apr 2006 15:56:47 +0200 |
User-agent: |
mutt-ng/devel-r578 (Linux) |
Hello Benjamin,
thank you very much for your _excellent_ bug report!
The rationale for changing sector_size to "long long" can be found
somewhere on this mailing list around the time the change was committed
and lies in automtical conversion.
Suppose you have an expression like this:
sector_size * MAX_INT
With "int sector_size" it will overflow, but with "long long
sector_size" the result will get promoted to "long long".
The bugs with the ioctl and the printf are of course genuine. The fix
for them will go into rc4, which I will probably release today.
I wonder why this bug did not appear earlier. Why would your setup
expose this bug? Do the PowerPC chips happen to be big-endian by any
chance?
Best wishes,
Leslie
PS: 1.7.0rc3 is the latest version, 1.7.1rc2 was just a typo and has
been deleted.
--
gpg --keyserver pgp.mit.edu --recv-keys 0x52D70289
http://nic-nac-project.de/~skypher/
pgpfJfkT3v180.pgp
Description: PGP signature