[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Parted says too much "Don't forget..."

From: Benno Schulenberg
Subject: Re: Parted says too much "Don't forget..."
Date: Sun, 15 Apr 2007 11:32:25 +0200
User-agent: KMail/1.9.6

Debarshi 'Rishi' Ray wrote:
> Please find attached a patch to address this issue. What do you
> say?

It does the job here, as far as I can see.  Nice.  Thanks.

But the identifier "is_disk_modified" would be better named 
"disk_is_modified", in my opinion -- because it is mostly assigned 
to and not inspected, and also because an occurrence is different 
from a mode.

More importantly: it needs to be set to zero upon declaration.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]