Re: parted-1.9.0 -- comments and patches

[Joel Granados]

On Fri, Jul 31, 2009 at 02:20:44PM -0600, Curtis Gedak wrote:
> Peter Breitenlohner wrote:
>>> ....  Did you test
>>> your patch.  Does it really fix the fact that that the test does not
>>> PASS. ...
>>
>> Yes, of course.  The result was the same when running the test via my
>> build+check+install script or when running 'make check' interactively  
>> in the
>> tests/ directory (of the build tree): FAIL without the patch, PASS  
>> with it.
>>
>>> ...  judging by your output, adding a "n" to the end of the string
>>> will not make it succeed.
>>
>> The difference is that the test (t7000-scripting) asks a question  
>> ansered by
>> 'n', whereas the example doesn't ask.  Thus the "echo n |" is ignored and
>> has no effect. 
>
> I too am experiencing a similar problem with failed tests when I run  
> "make check" on parted-1.9.0.
>
> I do not have the readline package installed and hence configure the  
> code with:
>
>     ./configure --without-readline
>

I just checked in my environment and this seems to work for me.  The
test passes even though I do a ./configure --without-readline.  Please
note that I am in next branch, not in master.  If you have not done your
tests in the next branch, I strongly suggest you repeat and post your
output.

Regards.

> Perhaps the failure of the two tests is related to whether readline is  
> installed or not?
>
> Regards,
> Curtis Gedak
>
>
> _______________________________________________
> bug-parted mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/bug-parted

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

pgpJSlrpi5ZVD.pgp
Description: PGP signature