[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [parted] ped_partition_busy should not call the libparted exception

From: Hans de Goede
Subject: Re: [parted] ped_partition_busy should not call the libparted exception handler
Date: Tue, 06 Oct 2009 12:04:49 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4


On 10/06/2009 11:54 AM, Jim Meyering wrote:
Hans de Goede wrote:
Modify libparted/arch/linux.c _partition_get_part_dev() to not call
_device_stat() but instead use stat directly, as _device_stat() calls
the libparted exception handler and we don't want this here, the only caller
of _partition_get_part_dev() is _partition_is_mounted(), which in turn only
gets called by linux_partition_is_busy(), and we don't want to "throw"
exceptions from ped_partition_busy()

This issue was noticed in combination with pyparted as used by anaconda, see:


I'm adding this to your commit.
If you'd like to adjust the wording, please let me know ASAP:

The wording is fine.

I wonder about the specific mention of the trouble this caused for anaconda,
is throwing exceptions not something which ped_partition_busy() should not
do in general? Just curious.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]