[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH parted] Handle swap flag in msdos type labels

From: Hans de Goede
Subject: Re: [PATCH parted] Handle swap flag in msdos type labels
Date: Sat, 10 Oct 2009 17:02:03 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4


On 10/10/2009 03:41 PM, Jim Meyering wrote:
Hans de Goede wrote:
From: David Cantrell<address@hidden>

Original patch by David Cantrell<address@hidden>, I
(Hans de Goede<address@hidden>) made the following changes:
-msdos_partition_is_flag_available() should return 1 for swap flag
-Only change the partition type to 82 when setting the swap flag
  on dos labels, not when resetting it

Hi Hans,

Thanks to both of you for the patch.

Can you outline a quick test or two to verify the
presence/absence of this fix?

Quite simple, make a msdos label, create a partition, set the swap
flag on it. Without this patch it should fail (haven't actually tested)
as msdos_partition_is_flag_available() returns 0 for the swap flag
and I expect the higher level functions to test this.

With this patch it accepts it, and the type of the created
partition table entry becomes 82 instead of 83.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]