[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH parted 1/5] libparted: add ped_device_get_xxx_aligment() func
Re: [PATCH parted 1/5] libparted: add ped_device_get_xxx_aligment() functions
Thu, 29 Oct 2009 09:28:31 +0100
Hans de Goede wrote:
>> Please add "const" and adjust spacing: space before "*", not after:
> I used the * placing which was already used in other parts of that file, but
> I'm happy to slowly mover over parted to a more sane coding style.
> Both fixed, I'll go over my entire patchset for this and other style issues,
> and then resend the set with all style issues (including trailing whitespace)
Thanks for being accommodating. It's hard even to request such
changes when most of the existing code is so ugly and inconsistent,
but we have to start somewhere.