[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH parted 3/3] linux: Remove PED_DEVICE_FILE check from _device_
Hans de Goede
Re: [PATCH parted 3/3] linux: Remove PED_DEVICE_FILE check from _device_set_sector_size
Fri, 29 Jan 2010 10:37:24 +0100
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:18.104.22.168) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0
On 01/29/2010 10:31 AM, Jim Meyering wrote:
Hans de Goede wrote:
_device_set_sector_size never get called for devices with a type of
PED_DEVICE_FILE, and having a PED_DEVICE_FILE check inside an ifdef
__390__ block does not make sense.
* libparted/arch/linux.c(_device_set_sector_size): Remove
That disjunct is indeed unnecessary. I added it in
dasd: allow the use of a *regular* backing file
thinking that it'd be required when running "make check" on an s390,
since many of those tests use a regular file as backing storage.
However, note that testing for PED_DEVICE_FILE inside s390-specific
code does make sense and is currently required in dasd.c, so I propose
to remove the "and having... does not make sense" part of your log
That is fine by me (removing that part of the log message).