Re: [RFC/PATCH 0/2] support for CMS-formatted disks on the s/390 architecture

[Jim Meyering]

Jonathan Nieder wrote:
> The inimitable Stephen Powell sent something like the two patches
> below to <http://bugs.debian.org/578097>.  It seems that they teach
> the dasd driver in parted to handle CMS-labeled partitions, which are
> a little more flexible and probably more common than the LDL format
> libparted already supports.
>
> Unfortunately, I do not have a specimen to experiment with, so I
> cannot say if my whitespace tweaks and so on broke the patch.
> Stephen, would it be possible to put up an image of a tiny partition
> to try this out with?
>
> The support is for reading only because that is what is most needed.
> I don’t imagine there would be any major technical obstacles to
> teaching parted to write these partitions, too.
>
> Thoughts?
> Jonathan
>
> Stephen Powell (2):
>   dasd: take sector size into account when calculating starting block
>   dasd: add read-only support for CMS labeled minidisks
>
>  NEWS                     |    7 +++++++
>  include/parted/vtoc.h    |   43 +++++++++++++++++++++++++++++++++++++++++++
>  libparted/labels/dasd.c  |   24 ++++++++++++++++++++----
>  libparted/labels/fdasd.c |   15 ++++++++-------
>  4 files changed, 78 insertions(+), 11 deletions(-)

Thanks for preparing those.
Can either of you outline a test for each that would fail before
application of a patch and succeed after it?