[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Need for a unique Linux GPT GUID type code (PATCH included)

From: Rod Smith
Subject: Re: Need for a unique Linux GPT GUID type code (PATCH included)
Date: Tue, 28 Jun 2011 13:46:42 -0400
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20110514 Lightning/1.0b3pre Thunderbird/3.1.10

On 06/27/2011 04:41 PM, Jim Meyering wrote:

Thanks for the improved patch.
If you include the following, the result will then pass "make check":
Your change is large enough that in order for us to be able
to use it, we'll need a copyright assignment.
See the "Copyright assignment" section of the HACKING file
for details.  Can you do that?

If so, would you please also update the documentation
(doc/parted.texi) to reflect this change?

It'd be even better if you would also add a brief description in NEWS
and a test suite addition or two to exercise it.

If you post more patches to the list, please follow the procedure
outlined in HACKING so that text something like your prose above ends
up being included the commit log. (i.e., you'd generate your patch file
with a command like "git format-patch --stdout -1>  DIFF").

I've made your suggested changes, except for the test suite -- I don't know enough about your test suites to even begin that task. I've also fired off the e-mail to the FSF for the copyright assignment forms, but I'll have to wait for postal mail for that process to complete. In the meantime, here's my latest patch, which consists of the changes to the three files I submitted earlier, plus changes to NEWS, parted.texi, and the change to t0220-gpt-msftres.sh that you suggested.

FWIW, I've also implemented support for this type code in my GPT fdisk programs, so all the Linux GPT partitioning tools will be nicely in sync on this issue as soon as these parted patches make it to a release version.

Rod Smith

Attachment: DIFF
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]