[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] tests: use more portable fd redirection in TESTS_ENVIRONMENT
From: |
Stefano Lattarini |
Subject: |
[PATCH] tests: use more portable fd redirection in TESTS_ENVIRONMENT |
Date: |
Wed, 12 Oct 2011 11:27:06 +0200 |
User-agent: |
KMail/1.13.7 (Linux/2.6.30-2-686; KDE/4.6.5; i686; ; ) |
You might also want to apply the attached follow-up, with prevents
an unportable usage of fd redirections in TESTS_ENVIRONMENT.
Regards,
Stefano
From edf499697383d60ccea896a96f5d21c2a5f4a155 Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Wed, 12 Oct 2011 11:18:47 +0200
Subject: [PATCH] tests: use more portable fd redirection in TESTS_ENVIRONMENT
* tests/Makefile.am (TESTS_ENVIRONMENT): Redirection with `exec 9>&2'
is not portable to various Korn shells, and to (at least) HP-UX 11
/bin/sh. Use a more portable idiom.
See <http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/22488> for
lots of discussion.
---
tests/Makefile.am | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index f7a170d..f70c524 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -80,7 +80,6 @@ sep = $(PATH_SEPARATOR)
TESTS_ENVIRONMENT = \
tmp__=$$TMPDIR; test -d "$$tmp__" || tmp__=.; \
TMPDIR=$$tmp__; export TMPDIR; \
- exec 9>&2; \
export \
abs_top_builddir='$(abs_top_builddir)' \
abs_top_srcdir='$(abs_top_srcdir)' \
@@ -100,6 +99,6 @@ TESTS_ENVIRONMENT = \
REPLACE_GETCWD=$(REPLACE_GETCWD) \
PATH='$(abs_top_builddir)/parted$(PATH_SEPARATOR)'"$$PATH" \
VERSION=$(VERSION) \
- ;
+ ; 9>&2
VERBOSE = yes
--
1.7.2.3